Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(aws-cdk-lib): ADOT Lambda Layer constants update - v0.32.0 #26801

Merged
merged 10 commits into from
Aug 24, 2023
Merged

fix(aws-cdk-lib): ADOT Lambda Layer constants update - v0.32.0 #26801

merged 10 commits into from
Aug 24, 2023

Conversation

vasireddy99
Copy link
Contributor

@vasireddy99 vasireddy99 commented Aug 18, 2023 •
edited
Loading

Update constants/doc for ADOT Lambda Layer
Reference PR - #26793

NOTE This PR requires an update to an integration test and am unable
to run the cdk-integ tool to perform a real deployment

By submitting this pull request, I confirm that I make my contribution under the terms of the Apache-2.0 license

@github-actions github-actions bot added repeat-contributor [Pilot] contributed between 3-5 PRs to the CDK p2 labels Aug 18, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team August 18, 2023 05:45
@vasireddy99 vasireddy99 mentioned this pull request Aug 18, 2023
Merged
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Aug 18, 2023
lpizzinidev
lpizzinidev suggested changes Aug 19, 2023
View reviewed changes
Copy link
Contributor

@lpizzinidev lpizzinidev left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!
Shouldn't the LATEST versions be updated as well?
If so, this integration test snapshot will need to be updated accordingly.

@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Aug 19, 2023
lpizzinidev
lpizzinidev reviewed Aug 22, 2023
View reviewed changes
Copy link
Contributor

@lpizzinidev lpizzinidev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This integration test template needs to be updated to match the new LATEST versions.

@mrgrain mrgrain changed the title chore(aws-cdk-lib): ADOT Lambda Layer constants update - v0.32.0 fix(aws-cdk-lib): ADOT Lambda Layer constants update - v0.32.0 Aug 22, 2023
@mrgrain mrgrain changed the title fix(aws-cdk-lib): ADOT Lambda Layer constants update - v0.32.0 fix(ws-cdk-lib): ADOT Lambda Layer constants update - v0.32.0 Aug 22, 2023
@mrgrain mrgrain changed the title fix(ws-cdk-lib): ADOT Lambda Layer constants update - v0.32.0 fix(aws-cdk-lib): ADOT Lambda Layer constants update - v0.32.0 Aug 22, 2023
aws-cdk-automation
aws-cdk-automation previously requested changes Aug 22, 2023
View reviewed changes
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@vasireddy99
Copy link
Contributor Author

vasireddy99 commented Aug 22, 2023 •
edited
Loading

I am seeking for Clarification Request, Also added a note in the PR description

@aws-cdk-automation aws-cdk-automation added the pr/reviewer-clarification-requested The contributor has requested clarification on feedback, a failing build, or a failing PR Linter run label Aug 22, 2023
@vasireddy99 vasireddy99 force-pushed the adotlambda branch 2 times, most recently from c1046c8 to ab83fa9 Compare August 23, 2023 18:07
@aws-cdk-automation aws-cdk-automation dismissed their stale review August 23, 2023 18:09

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Aug 24, 2023
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 6795e32
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Aug 24, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit ad9d764 into aws:main Aug 24, 2023
12 checks passed
@vasireddy99 vasireddy99 deleted the adotlambda branch August 24, 2023 15:07
@github-actions github-actions bot mentioned this pull request Sep 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpizzinidev lpizzinidev lpizzinidev approved these changes

@mrgrain mrgrain mrgrain approved these changes

@aws-cdk-automation aws-cdk-automation aws-cdk-automation left review comments

Assignees
No one assigned
Labels
p2 pr/needs-maintainer-review This PR needs a review from a Core Team Member pr/reviewer-clarification-requested The contributor has requested clarification on feedback, a failing build, or a failing PR Linter run repeat-contributor [Pilot] contributed between 3-5 PRs to the CDK
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vasireddy99 @aws-cdk-automation @mrgrain @lpizzinidev